-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct output redirection #929
Correct output redirection #929
Conversation
Hey hey, @DominikKamp, glad to see you here 😄 We had some problems with printing and people having weird locales (#830, #843). Do you think we might need to be concerned with this here as well? Also, can you please add some tests? |
The function
I do not really know, how the console output could be tested. But it could be tested that |
Yeah, the output itself should be hard to test, but just that it's being printed to the correct place. We have a bunch of The test function needs to be prefixed by |
Tests added but please verify that the console output is still as expected with and without |
Before doing anything else, it seems like the mac pipeline has to be fixed because the github runner is not able to compile the SCIPOptSuite before eternity ends (why not use the precompiled version like in the Windows-test?). |
Changes look good. I will test before merging. |
This does fix the issue on |
Let's wait until #933 is merged as then the pipelines can run faster |
This resolves #243 by restricting method
redirectOutput()
to the streamsstdout
andstderr
.